netdev - Re: [PATCH] ath9k: fix a memory leak in ath_rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1332325263.25742.17.camel@edumazet-laptop>
Date:	Wed, 21 Mar 2012 03:21:03 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	"John W. Linville" <linville@...driver.com>
Cc:	David Miller <davem@...emloft.net>,
	Jouni Malinen <jouni@....qualcomm.com>,
	Felix Fietkau <nbd@...nwrt.org>,
	Trond Wuellner <trond@...omium.org>,
	Grant Grundler <grundler@...omium.org>,
	Paul Stewart <pstew@...omium.org>,
	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH] ath9k: fix a memory leak in ath_rx_tasklet()

Le vendredi 16 mars 2012 à 10:00 -0400, John W. Linville a écrit :
> On Thu, Mar 15, 2012 at 01:43:29PM -0700, Eric Dumazet wrote:
> > commit 0d95521ea7 (ath9k: use split rx buffers to get rid of order-1 skb
> > allocations) added in memory leak in error path.
> > 
> > sc->rx.frag should be cleared after the pskb_expand_head() call, or else
> > we jump to requeue_drop_frag and leak an skb.
> > 
> > Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>
> > Cc: Jouni Malinen <jouni@....qualcomm.com>
> > Cc: Felix Fietkau <nbd@...nwrt.org>
> > Cc: John W. Linville <linville@...driver.com>
> > Cc: Trond Wuellner <trond@...omium.org>
> > Cc: Grant Grundler <grundler@...omium.org>
> > Cc: Paul Stewart <pstew@...omium.org>
> > Cc: David Miller <davem@...emloft.net>
> 
> Acked-by: John W. Linville <linville@...driver.com>
> 
> Dave, will you pick this up yourself?  Or should I take it around the bend?

I dont know, please make sure its not lost anyway :

I have an upcoming patch on top on this one to reduce ath9k skb truesize
by 50% and get better tcp receives.



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html