| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 21 Mar 2012 09:20:14 -0700 From: Ben Greear <greearb@...delatech.com> To: Ben Hutchings <bhutchings@...arflare.com> CC: Sujith Manoharan <c_manoha@....qualcomm.com>, linux-wireless@...r.kernel.org, netdev@...r.kernel.org Subject: Re: [PATCH v3 4/4] ath9k: Support ethtool getstats api. On 03/21/2012 09:10 AM, Ben Hutchings wrote: > On Wed, 2012-03-21 at 12:37 +0530, Sujith Manoharan wrote: >> Ben Greear wrote: >>> I'd like to gather at least most stats always, so ethtool can work regardless >>> of debugfs. But, that can be follow on patches in my opinion. If it turns >>> out that we need another config option for this, then that is fine too. >> >> It would be good to have an option to compile this out. The information is >> available via the debugfs interface, so this is basically duplicating things. >> On APs using OpenWRT, debugfs is enabled by default, so we can just read >> the debugfs files. > > ethtool is the normal way to expose extended network stats, so the > debugfs interface should be dropped in favour of this. No...ath9k debugfs offers a lot of additional info that is not easily packaged into ethtool stats, and is better formatted for reading by humans. So, both should be kept..though we can optionally compile out both/either/none. Thanks, Ben -- Ben Greear <greearb@...delatech.com> Candela Technologies Inc http://www.candelatech.com -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists