netdev - Re: [PATCH] net: fix napi_reuse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120321.165624.972276388107342047.davem@davemloft.net>
Date:	Wed, 21 Mar 2012 16:56:24 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	herbert@...dor.hengli.com.au, netdev@...r.kernel.org
Subject: Re: [PATCH] net: fix napi_reuse_skb() skb reserve

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Wed, 21 Mar 2012 09:58:03 -0700

> napi->skb is allocated in napi_get_frags() using
> netdev_alloc_skb_ip_align(), with a reserve of NET_SKB_PAD +
> NET_IP_ALIGN bytes.
> 
> However, when such skb is recycled in napi_reuse_skb(), it ends with a
> reserve of NET_IP_ALIGN which is suboptimal.
> 
> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>
> Cc: Herbert Xu <herbert@...dor.apana.org.au>

Applied and queued up for -stable, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html