netdev - Re: [PATCH] sh: sh_eth: Add support SH7734

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120321.165818.1166540551487888245.davem@davemloft.net>
Date:	Wed, 21 Mar 2012 16:58:18 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	nobuhiro.iwamatsu.yj@...esas.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] sh: sh_eth: Add support SH7734

From: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@...esas.com>
Date: Wed, 21 Mar 2012 16:13:34 +0900

> Add define of SH7734 register and sh_eth_reset_hw_crc function.
> 
> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@...esas.com>

This patch doesn't apply cleanly at all, also:

> -#elif defined(CONFIG_CPU_SUBTYPE_SH7763)
> +#elif defined(CONFIG_CPU_SUBTYPE_SH7734) ||\
> +		defined(CONFIG_CPU_SUBTYPE_SH7763)

This looks terrible, please don't split this line up like that.

If you have to, at least put a space before the backslash at the end
of the first line and make the "defined" on the second line match up,
column wise, with the "defined" on the previous line.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html