lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 22 Mar 2012 21:26:23 +0300 From: Dan Carpenter <dan.carpenter@...cle.com> To: rusty@...tcorp.com.au Cc: netdev@...r.kernel.org Subject: re: module_param: make bool parameters really bool (net & drivers/net) Hi Rusty, The patch eb93992207da: "module_param: make bool parameters really bool (net & drivers/net)" from Dec 19, 2011, leads to the following warning: net/ipv4/netfilter/iptable_filter.c:90 iptable_filter_init() warn: 5 is more than 1 (max 'forward' can be) so this is always the same. It's declared like this: 54 /* Default to forward because I got too much mail already. */ 55 static bool forward = NF_ACCEPT; 56 module_param(forward, bool, 0000); It's used like this: 66 ((struct ipt_standard *)repl->entries)[1].target.verdict = -forward - 1; Smatch complains when check that it's larger than 5. 90 if (forward < 0 || forward > NF_MAX_VERDICT) { 91 pr_err("iptables forward must be 0 or 1\n"); 92 return -EINVAL; 93 } regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists