netdev - Re: [PATCH net] tg3: Fix RSS ring refill race condition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120321.215824.1259388773873717864.davem@davemloft.net>
Date:	Wed, 21 Mar 2012 21:58:24 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	mchan@...adcom.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net] tg3: Fix RSS ring refill race condition

From: "Michael Chan" <mchan@...adcom.com>
Date: Wed, 21 Mar 2012 17:38:33 -0800

> The RSS feature in tg3 hardware has only one rx producer ring for all
> RSS rings.  NAPI vector 1 is special and handles the refilling of the
> rx producer ring on behalf of all RSS rings.  There is a race condition
> between these RSS NAPIs and the NAPI[1].  If NAPI[1] finishes checking
> for refill and then another RSS ring empties the rx producer ring
> before NAPI[1] exits NAPI, the chip will be completely out of SKBs in
> the rx producer ring.
> 
> We fix this by adding a flag tp->rx_refill and rely on napi_schedule()/
> napi_complete() to help synchronize it to close the race condition.
> 
> Update driver version to 3.123.
> 
> Signed-off-by: Michael Chan <mchan@...adcom.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html