lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 22 Mar 2012 16:45:43 -0700 From: Roland Dreier <roland@...estorage.com> To: Jason Gunthorpe <jgunthorpe@...idianresearch.com> Cc: Parav.Pandit@...lex.com, David.Laight@...lab.com, linux-rdma@...r.kernel.org, netdev@...r.kernel.org Subject: Re: [PATCH 2/9] ocrdma: Driver for Emulex OneConnect RDMA adapter On Thu, Mar 22, 2012 at 3:44 PM, Jason Gunthorpe <jgunthorpe@...idianresearch.com> wrote: > For hardware facing structures I'd combine this with a static assert > to verify structure size at compile time. > > So.. > > 1) Avoid using attributes unless the structure has unaligned members. > 2) Avoid creating structures with unaligned members (eg for userspace > communication) > 3) Frown at hardware/firmware developers who make communication > structures with unaligned members :) > 4) Be explicit about padding in your layout for 64/32 > compatibility. Excellent summary, thanks Jason. - R. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists