netdev - [RFC] skb truesize last offenders

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <1332507112.4858.12.camel@edumazet-laptop>
Date:	Fri, 23 Mar 2012 05:51:52 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev <netdev@...r.kernel.org>,
	Wey-Yi Guy <wey-yi.w.guy@...el.com>
Subject: [RFC] skb truesize last offenders

iwlwifi and some other users of skb_add_rx_frag() lie about skb
truesize, because of API being lazy.

iwlwifi can use order-0 or order-1 pages and skb truesize is wrong.
network sbs can use uncharged kernel memory and eventually crash machine
in OOM.

I plan : 

1) adding a @truesize parameter to skb_add_rx_frag() in a neutral patch

2) fix drivers that dont charge the real size of fragment

3) niu could then use skb_add_rx_frag() instead of custom code.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html