netdev - Re: [RFC] skb truesize last offenders

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1332528919.2516.2.camel@edumazet-glaptop>
Date:	Fri, 23 Mar 2012 11:55:19 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org, wey-yi.w.guy@...el.com,
	Neal Cardwell <ncardwell@...gle.com>
Subject: Re: [RFC] skb truesize last offenders

On Fri, 2012-03-23 at 14:38 -0400, David Miller wrote:
> From: Eric Dumazet <eric.dumazet@...il.com>
> Date: Fri, 23 Mar 2012 05:51:52 -0700
> 
> > iwlwifi and some other users of skb_add_rx_frag() lie about skb
> > truesize, because of API being lazy.
> > 
> > iwlwifi can use order-0 or order-1 pages and skb truesize is wrong.
> > network sbs can use uncharged kernel memory and eventually crash machine
> > in OOM.
> > 
> > I plan : 
> > 
> > 1) adding a @truesize parameter to skb_add_rx_frag() in a neutral patch
> > 
> > 2) fix drivers that dont charge the real size of fragment
> > 
> > 3) niu could then use skb_add_rx_frag() instead of custom code.
> 
> No objections from me.  But we really have to fix that
> tcp_grow_window() issue, it's quite urgent if you ask me.

Sure, I can work on this issue with Neal asap, we do have some ideas on
this subject.



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html