netdev - Re: [PATCH v2] iwlwifi: fix skb truesize underestimation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1332603328.27767.11.camel@wwguy-huron>
Date:	Sat, 24 Mar 2012 08:35:28 -0700
From:	"Guy, Wey-Yi" <wey-yi.w.guy@...el.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	Neal Cardwell <ncardwell@...gle.com>,
	"John W. Linville" <linville@...driver.com>
Subject: Re: [PATCH v2] iwlwifi: fix skb truesize underestimation

Hi Eric,

On Fri, 2012-03-23 at 17:29 -0700, Eric Dumazet wrote:
> By default, iwlwifi uses order-1 pages (8 KB) to store incoming frames,
> but doesnt say so in skb->truesize.
> 
> This makes very possible to exhaust kernel memory since these skb evade
> normal socket memory accounting.
> 
> As struct ieee80211_hdr is going to be pulled before calling IP stack,
> there is no need to use dev_alloc_skb() to reserve NET_SKB_PAD bytes.
> alloc_skb() is ok in this driver, allowing more tailroom.
> 
> Pull beginning of frame in skb header, in the hope we can reuse order-1
> pages in the driver immediately for small frames and reduce their
> truesize to the minimum (linear skbs)
> 
> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>
> Cc: Wey-Yi Guy <wey-yi.w.guy@...el.com>
> Cc: "John W. Linville" <linville@...driver.com>
> Cc: Neal Cardwell <ncardwell@...gle.com>
> ---

Is it ok I pull your patch into our internal tree first for regression
testing, once the test is done, I will push your patch along with all
our other patches together to wireless-next(John Linville).

By doing so, first, we know the patch is not breaking any functionality
for all the devices(legacy/new), second, it is easier for us to sync-up
with all the other changes we are making now.

Thanks
Wey

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html