netdev - Re: [PATCH] iwlwifi: fix skb truesize underestimation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1332548545.2516.134.camel@edumazet-glaptop>
Date:	Fri, 23 Mar 2012 17:22:25 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org, wey-yi.w.guy@...el.com,
	Neal Cardwell <ncardwell@...gle.com>,
	"John W. Linville" <linville@...driver.com>
Subject: Re: [PATCH] iwlwifi: fix skb truesize underestimation

On Fri, 2012-03-23 at 17:05 -0700, Eric Dumazet wrote:
> +	if (len) {
> +		int offset = (void *)hdr + hdrlen - rxb_addr(rxb);
> + 
> +		skb_add_rx_frag(skb, 0, rxb_steal_page(rxb), offset,
> +				len, rxb->truesize);
> +	}
>  	iwl_update_stats(priv, false, fc, len);
>  

Please delete this patch, I'll send a v2 : iwl_update_stats() should be
called with original "len", not "len - hdrlen"


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html