netdev - Re: [PATCH] net: reference the ipv4 sysctl table header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120326.182411.41401140080225401.davem@davemloft.net>
Date:	Mon, 26 Mar 2012 18:24:11 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	tixxdz@...ndz.org
Cc:	ebiederm@...ssion.com, viro@...iv.linux.org.uk,
	netdev@...r.kernel.org
Subject: Re: [PATCH] net: reference the ipv4 sysctl table header

From: Djalal Harouni <tixxdz@...ndz.org>
Date: Mon, 26 Mar 2012 23:23:59 +0100

> +static struct ctl_table_header *ip4_base;
> +
>  /*
>   * We really need to sanitize the damn ipv4 init order, then all
>   * this nonsense will go away.
>   */
> -void __init ip_static_sysctl_init(void)
> +int __init ip_static_sysctl_init(void)
>  {
> -	register_sysctl_paths(ipv4_path, ipv4_skeleton);
> +	ip4_base = register_sysctl_paths(ipv4_path, ipv4_skeleton);

This is so incredibly stupid, just panic() or similar if this
returns NULL.

And find another way to annotate this for memleak so we don't need to
waste an entire pointer, which is never used, in the data section.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html