netdev - Re: [PATCH] eql: Fix byte stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1332835965.3248.2.camel@edumazet-laptop>
Date:	Tue, 27 Mar 2012 01:12:45 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	David Woodhouse <dwmw2@...radead.org>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] eql: Fix byte stats

Le lundi 26 mars 2012 à 08:29 +0100, David Woodhouse a écrit :

Missing changelog and "Signed-off-by: ..."

> ---
> Sorry, forgot to tell Evolution not to word-wrap last time. It's a
> manual process — insert the patch from a text file, and set it to
> 'Preformatted'. I've also disabled the signature on this version; I'm
> not entirely sure if the git-am bug with QP got fixed yet.
> 

I use Evolution too, its not that bad :)

> diff --git a/drivers/net/eql.c b/drivers/net/eql.c
> index a59cf96..f2d3741 100644
> --- a/drivers/net/eql.c
> +++ b/drivers/net/eql.c
> @@ -345,6 +345,7 @@ static netdev_tx_t eql_slave_xmit(struct sk_buff *skb, struct net_device *dev)
>  		slave->bytes_queued += skb->len;
>  		dev_queue_xmit(skb);
>  		dev->stats.tx_packets++;
> +		dev->stats.tx_bytes += skb->len;
>  	} else {
>  		dev->stats.tx_dropped++;
>  		dev_kfree_skb(skb);
> 

That adds a bug unfortunately.

After dev_queue_xmit(skb) call, you cant safely dereference skb anymore.



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html