netdev - Re: [PATCH net/core] dev_forward_skb() should clear skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120327.173707.226441470555050908.davem@davemloft.net>
Date:	Tue, 27 Mar 2012 17:37:07 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	bcrl@...ck.org
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net/core] dev_forward_skb() should clear skb_iif

From: Benjamin LaHaise <bcrl@...ck.org>
Date: Tue, 27 Mar 2012 12:29:20 -0400

> While investigating another bug, I found that the code on the incoming path
> in __netif_receive_skb will only set skb->skb_iif if it is already 0.  When
> dev_forward_skb() is used in the case of interfaces like veth, skb_iif may
> already have been set.  Making dev_forward_skb() cause the packet to look
> more like a newly received packet would seem to the the correct behaviour
> here, as otherwise the wrong incoming interface can be reported for such a
> packet.

Same problems as your ipv4 multicast patch, I'm not applying this.

You must learn how to properly submit your changes, otherwise I
guarentee all of your work will hit the bit bucket.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html