netdev - Re: [PATCH V3 0/6] net/mlx4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZOPZLLJdQX4i_WhV8Bo5UHaxndFDwf873n8ZTCPqXq7JrMiw@mail.gmail.com>
Date:	Thu, 29 Mar 2012 00:21:57 +0200
From:	Or Gerlitz <or.gerlitz@...il.com>
To:	"David S. Miller" <davem@...emloft.net>
Cc:	netdev@...r.kernel.org, Roland Dreier <roland@...estorage.com>,
	Yevgeny Petrilin <yevgenyp@...lanox.com>,
	Oren Duer <oren@...lanox.com>,
	Amir Vadai <amirv@....mellanox.co.il>,
	John Fastabend <john.r.fastabend@...el.com>,
	Eric Dumazet <eric.dumazet@...il.com>,
	Amir Vadai <amirv@...lanox.com>
Subject: Re: [PATCH V3 0/6] net/mlx4_en: DCB QoS support

On Tue, Mar 27, 2012 at 5:09 PM, Amir Vadai <amirv@...lanox.com> wrote:
> DCBX version 802.1qaz is supported.
> User Priority (UP) is set in QP context instead of in WQE (QP Work Queue
> Element), which means that all traffic from a queue will have the same UP.
> UP is also set for untagged traffic to be able to classify such traffic too.
>
> Mapping from sk_prio to User Priority is done by sch_mqprio mapping. Although
> confusingly sch_mqprio maps sk_prio to something called TC, it is not related
> to DCBX's TC, and is interpreted by mlx4_en driver as UP.

Hi Dave,

Haven't seen a comment from you on this patch set, just wanted to
double check some points are clarified:  as was raised in the internal
review, from V0 Amir pointed out on the ratelimit patch (doesn't fit
into the current DCBNL framework) and on the queue selection patch
(changes the spirit of the HW QoS work from Jonh) that they might need
changes -  but we preferred to come up with code and not only
theoretic suggestions.

For the ratelimit Eric D. provided feedback and it was implemented
along his suggestion,
and now John and Ben have other suggestions, so need clear feedback
here not to implement this in 2-3 different ways, and this is the
easier piece. As for the HW QoS, the discussion continues.

V3 has patches 1-6 on which no objecting comment was provided, and
they should be okay for merging, unless you see things which need to
change there?

Or.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html