netdev - Re: [PATCH] rose_dev: fix memcpy-bug in rose_set_mac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120327.224934.2217174765482571048.davem@davemloft.net>
Date:	Tue, 27 Mar 2012 22:49:34 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	danborkmann@...earbox.net
Cc:	ralf@...ux-mips.org, netdev@...r.kernel.org
Subject: Re: [PATCH] rose_dev: fix memcpy-bug in rose_set_mac_address

From: Daniel Borkmann <danborkmann@...earbox.net>
Date: Tue, 27 Mar 2012 15:27:56 +0200

> This patch fixes a small bug in rose_set_mac_address. If the current and new
> MAC addresses match, then nothing needs to be done. However memcpy was used
> instead of memcmp for comparison.
> 
> The patch is against the latest net-tree.
> 
> Signed-off-by: Daniel Borkmann <daniel.borkmann@....ee.ethz.ch>

You're breaking this code, not fixing it.

If you don't keep the memcpy, then the calls right below which setup
the loopback node will use the previous device address not the new
one being configured.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html