netdev - RE: [PATCH net-next 2/5] r8169: add csi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <C4853E741FE64400AFA06E6FB7B634D9@realtek.com.tw>
Date:	Wed, 28 Mar 2012 10:52:24 +0800
From:	hayeswang <hayeswang@...ltek.com>
To:	'Francois Romieu' <romieu@...zoreil.com>
CC:	<netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH net-next 2/5] r8169: add csi_opt

 Francois Romieu [mailto:romieu@...zoreil.com] 
 [...]
> > -static void rtl_csi_access_enable_2(void __iomem *ioaddr)
> > +static void __devinit rtl_init_csi_ops(struct rtl8169_private *tp)
> >  {
> > -	rtl_csi_access_enable(ioaddr, 0x27000000);
> > +	struct csi_ops *ops = &tp->csi_ops;
> > +
> > +	switch (tp->mac_version) {
> > +	default:
> > +		ops->write	= r8169_csi_write;
> > +		ops->read	= r8169_csi_read;
> > +		break;
> > +	}
> >  }
> >  
> >  struct ephy_info {
> [...]
> > @@ -6199,6 +6267,7 @@ rtl_init_one(struct pci_dev *pdev, 
> const struct pci_device_id *ent)
> >  	rtl_init_mdio_ops(tp);
> >  	rtl_init_pll_power_ops(tp);
> >  	rtl_init_jumbo_ops(tp);
> > +	rtl_init_csi_ops(tp);
> >  
> >  	rtl8169_print_mac_version(tp);
> 
> It will enable the CSI read/write functions where they 
> previously weren't.
> 
> Is it really supposed to behave this way ?
> 
> Thanks.
> 

It seems to be fine, but I would modify them. Thanks.
 
Best Regards,
Hayes

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html