netdev - Re: [PATCH] tcp: bind() use stronger condition for bind

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 28 Mar 2012 16:48:33 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Flavio Leitner <fbl@...hat.com>
Cc:	Alexandru Copot <alex.mihai.c@...il.com>, davem@...emloft.net,
	kuznet@....inr.ac.ru, jmorris@...ei.org, yoshfuji@...ux-ipv6.org,
	kaber@...sh.net, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, Daniel Baluta <dbaluta@...acom.com>
Subject: Re: [PATCH] tcp: bind() use stronger condition for bind_conflict

On Wed, 2012-03-28 at 10:52 -0300, Flavio Leitner wrote:
> On Wed, 28 Mar 2012 00:11:52 +0300
> Alexandru Copot <alex.mihai.c@...il.com> wrote:
> 

> > diff --git a/net/ipv6/inet6_connection_sock.c b/net/ipv6/inet6_connection_sock.c
> > index 02dd203..dfc8bc3 100644
> > --- a/net/ipv6/inet6_connection_sock.c
> > +++ b/net/ipv6/inet6_connection_sock.c
> > @@ -28,7 +28,8 @@
> >  #include <net/inet6_connection_sock.h>
> >  
> >  int inet6_csk_bind_conflict(const struct sock *sk,
> > -			    const struct inet_bind_bucket *tb)
> > +			    const struct inet_bind_bucket *tb,
> > +				int relax)
> 
> Same here
> Maybe you can wait for more feedbacks before spin another patch 
> version just to fix that.
> 



Also 'int relax' should be 'bool relax'... 1/0 -> true/false

Anyway net-next is not open yet...


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html