netdev - Re: [PATCH] marvell sky2 driver: fix so it works without unaligned accesses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120403091750.11eff45b@s6510.linuxnetplumber.net>
Date:	Tue, 3 Apr 2012 09:17:50 -0700
From:	Stephen Hemminger <shemminger@...tta.com>
To:	Chris Metcalf <cmetcalf@...era.com>
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] marvell sky2 driver: fix so it works without unaligned
 accesses

On Tue, 3 Apr 2012 11:13:56 -0400
Chris Metcalf <cmetcalf@...era.com> wrote:

> The driver uses a receive_new() routine that ends up requiring unaligned
> accesses in IP header processing.  If the architecture doesn't support
> efficient unaligned accesses, just copy all ingress packets to the bounce
> buffers instead.
> 
> This allows the driver to be used on the Tilera TILEmpower-Gx, since
> the tile architecture doesn't currently handle kernel unaligned accesses,
> just userspace.
> 
> Signed-off-by: Chris Metcalf <cmetcalf@...era.com>

There are many other encapsulation cases where IP header won't be
aligned. Why not just set copybreak module option to a very large value?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html