[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20120403115547.799fcc1f@s6510.linuxnetplumber.net>
Date: Tue, 3 Apr 2012 11:55:47 -0700
From: Stephen Hemminger <shemminger@...tta.com>
To: Lino Sanfilippo <LinoSanfilippo@....de>
Cc: linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH] sky2: fix missing register reset on error path in
sky2_test_msi()
On Fri, 30 Mar 2012 19:36:16 +0200
Lino Sanfilippo <LinoSanfilippo@....de> wrote:
> In sky2_test_msi() the temporarily set SW IRQ in B0 register is not reset in case
> that request_irq() fails.
> With this patch we only set the interrupt mask if request_irq() was successful.
>
> Signed-off-by: Lino Sanfilippo <LinoSanfilippo@....de>
Ok, but this is a non-serious error case. If request_irq() fails here,
the driver is going to fail to load and on the failure path of
sky2_probe will reset the chip on the way out.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists