netdev - Re: [PATCH V3 net-next 00/28] ethtool: support time stamping and phc clocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120403.162542.2077088434639546515.davem@davemloft.net>
Date:	Tue, 03 Apr 2012 16:25:42 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	richardcochran@...il.com
Cc:	netdev@...r.kernel.org, bhutchings@...arflare.com,
	mporter@...arflare.com, jacob.e.keller@...el.com,
	jeffrey.t.kirsher@...el.com, john.ronciak@...el.com,
	e1000-devel@...ts.sourceforge.net
Subject: Re: [PATCH V3 net-next 00/28] ethtool: support time stamping and
 phc clocks

From: Richard Cochran <richardcochran@...il.com>
Date: Tue,  3 Apr 2012 19:47:24 +0200

> The new feature has been tested on the following hardware:
> 
> igb       Hardware time stamping in the MAC

I don't know how, it doesn't even build.

drivers/net/ethernet/intel/igb/igb_ethtool.c: In function ‘igb_ethtool_get_ts_info’:
drivers/net/ethernet/intel/igb/igb_ethtool.c:2195:13: error: ‘struct igb_adapter’ has no member named ‘ptp_clock’
drivers/net/ethernet/intel/igb/igb_ethtool.c:2196:3: error: implicit declaration of function ‘ptp_clock_index’ [-Werror=implicit-function-declaration]
drivers/net/ethernet/intel/igb/igb_ethtool.c:2196:44: error: ‘struct igb_adapter’ has no member named ‘ptp_clock’

If these patches depend upon changes not in my tree, and you haven't
even mentioned this, I'm going to be _extremely_ irritated.