netdev - Re: [patch net-next 3/4] team: add binary option type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120403.183816.230619298656469157.davem@davemloft.net>
Date:	Tue, 03 Apr 2012 18:38:16 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	jpirko@...hat.com
Cc:	netdev@...r.kernel.org, eric.dumazet@...il.com,
	bhutchings@...arflare.com, shemminger@...tta.com,
	raise.sail@...il.com, nuno.martins@...xamagica.pt, matt@...abs.org
Subject: Re: [patch net-next 3/4] team: add binary option type

From: Jiri Pirko <jpirko@...hat.com>
Date: Sat, 31 Mar 2012 23:01:21 +0200

> For transfering generic binary data (e.g. BPF code), introduce new
> binary option type.
> 
> Signed-off-by: Jiri Pirko <jpirko@...hat.com>

Several issues:

> +		struct team_option_binary tbinary;

You put this into a netlink attribute, it has a non-fixed
type size because it uses pointer.  A compat task will do
the wrong thing and you won't interpret it's attribute
correctly.

> +			NLA_PUT_U8(skb, TEAM_ATTR_OPTION_TYPE, NLA_BINARY);

net-next no longer has NLA_PUT*(), so you'll need to adjust
this as well.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html