netdev - Re: [PATCH] netfilter: xt_CT: remove a compile warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120403093538.GA20140@1984>
Date:	Tue, 3 Apr 2012 11:35:38 +0200
From:	Pablo Neira Ayuso <pablo@...filter.org>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	David Miller <davem@...emloft.net>, netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH] netfilter: xt_CT: remove a compile warning

On Tue, Apr 03, 2012 at 10:31:23AM +0200, Eric Dumazet wrote:
> On Tue, 2012-04-03 at 10:17 +0200, Pablo Neira Ayuso wrote:
> > On Tue, Apr 03, 2012 at 05:48:22AM +0200, Eric Dumazet wrote:
> > > If CONFIG_NF_CONNTRACK_TIMEOUT=n we have following warning :
> > > 
> > >   CC [M]  net/netfilter/xt_CT.o
> > > net/netfilter/xt_CT.c: In function ‘xt_ct_tg_check_v1’:
> > > net/netfilter/xt_CT.c:284: warning: label ‘err4’ defined but not used
> > 
> > Thanks Eric.
> > 
> > I think I prefer the one attached.
> > 
> > I 'll pass it to davem with a couple of other minor fixes anytime soon.
> 
> Its your call, but you should move the whole
> 
> #if CONFIG_NF_CONNTRACK_TIMEOUT
> 	... lot of lines ...
> #endif
> 
> in a helper function to make things a bit more maintainable

I will, thanks for the suggestion.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html