lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 03 Apr 2012 08:36:48 -0700 From: Ben Greear <greearb@...delatech.com> To: Eric Dumazet <eric.dumazet@...il.com> CC: David Miller <davem@...emloft.net>, NetDev <netdev@...r.kernel.org>, Mihai Maruseac <mmaruseac@...acom.com> Subject: Re: [PATCH net: fix /proc/net/dev regression On 04/03/2012 01:33 AM, Eric Dumazet wrote: > Commit f04565ddf52 (dev: use name hash for dev_seq_ops) added a second > regression, as some devices are missing from /proc/net/dev if many > devices are defined. > > When seq_file buffer is filled, the last ->next/show() method is > canceled (pos value is reverted to value prior ->next() call) > > Problem is after above commit, we dont restart the lookup at right > position in ->start() method. > > Fix this by removing the internal 'pos' pointer added in commit, since > we need to use the 'loff_t *pos' provided by seq_file layer. > > This also reverts commit 5cac98dd0 (net: Fix corruption > in /proc/*/net/dev_mcast), since its not needed anymore. > > Reported-by: Ben Greear<greearb@...delatech.com> > Signed-off-by: Eric Dumazet<eric.dumazet@...il.com> > Cc: Mihai Maruseac<mmaruseac@...acom.com> This appears to fix the problem. I do find it mildly irritating that the ordering is now random in /proc/net/dev, but I guess that is the price of progress. Tested-by: Ben Greear <greearb@...delatech.com> Thanks for the quick fix! Ben -- Ben Greear <greearb@...delatech.com> Candela Technologies Inc http://www.candelatech.com -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists