netdev - Re: [PATCH net-next 2/2] e100: enable transmit time stamping.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 04 Apr 2012 02:34:48 -0700
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	Richard Cochran <richardcochran@...il.com>
Cc:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	David Miller <davem@...emloft.net>
Subject: Re: [PATCH net-next 2/2] e100: enable transmit time stamping.

On Wed, 2012-04-04 at 11:30 +0200, Richard Cochran wrote:
> On Wed, Apr 04, 2012 at 02:04:43AM -0700, Jeff Kirsher wrote:
> > 
> > I had this patch in my queue, but during testing we found some serious
> > issues with some adapters.  With every 82559 based adapter Aaron tried
> > the system would panic on driver load.  This included at least one
> > sampling of D101S and D101M.  Every other e100 chipset Aaron tried
> > (82557, 82558, 82550) appeared to work fine.
> > 
> > So I am dropping this patch as is due to the kernel panics.
> 
> Okay, fine. That driver is strangely written, with weird callbacks and
> passing function pointers around.
> 
> Taking a second look, I think I might have found the problem. The
> drivers casts a firmware pointer onto a skb, and my patch then tries
> to timestamp the firmware blob.
> 
> If I rework this, are you willing to give it another try?
> 
> Thanks,
> Richard

Yeah, we appreciate the work your doing.  Just send me an updated patch
and I will add it to my queue.

That was our thoughts as well regarding the firmware blobs.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)