netdev - Re: [PATCH net V1 2/2] net/bonding: correctly proxy slave neigh param setup ndo function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 04 Apr 2012 18:12:13 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	ogerlitz@...lanox.com
Cc:	roland@...nel.org, netdev@...r.kernel.org, fubar@...ibm.com,
	shlomop@...lanox.com
Subject: Re: [PATCH net V1 2/2] net/bonding: correctly proxy slave neigh
 param setup ndo function

From: Or Gerlitz <ogerlitz@...lanox.com>
Date: Wed,  4 Apr 2012 11:56:20 +0300

> From: Shlomo Pongratz <shlomop@...lanox.com>
> 
> The current implemenation was buggy for slaves who use ndo_neigh_setup,
> since the networking stack invokes the bonding device ndo entry (from
> neigh_params_alloc) before any devices are enslaved, and the bonding
> driver can't further delegate the call at that point in time. As a
> result when bonding IPoIB devices, the neigh_cleanup hasn't been called.
> 
> Fix that by deferring the actual call into the slave ndo_neigh_setup
> from the time the bonding neigh_setup is called.
> 
> Signed-off-by: Shlomo Pongratz <shlomop@...lanox.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html