netdev - Re: [PATCH 0/7] bna: Update driver version to 3.0.23.0 (resubmit)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 04 Apr 2012 18:21:05 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	huangj@...cade.COM
Cc:	netdev@...r.kernel.org, AdapterLinuxOpenSrcExtTeam@...cade.COM
Subject: Re: [PATCH 0/7] bna: Update driver version to 3.0.23.0 (resubmit)

From: Jing Huang <huangj@...cade.COM>
Date: Wed, 4 Apr 2012 08:41:42 -0700

> I am resubmit this patch set since it seems that the net-next merge window is
> over. 
> 
> This patch set contains fixes in adapter initialization and tx/rx cleanup path.
> It also include code cleanups by removing and renaming some functions.
> 
> The driver version has been updated to 3.0.23.0 to reflect the changes.

All applied.

But I would suggest modifying how the driver spins waiting for the
firmware to release semaphore bits in registers.

You have no timeouts or limits in these loops.

So if the firmware crashes or gets stuck, this will take out the
entire computer which is very undesirable.

Change these loops to have a limit and signal an error and fail the
top-level operation if the limit is hit.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html