[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 04 Apr 2012 18:28:38 -0400 (EDT)
From: David Miller <davem@...emloft.net>
To: or.gerlitz@...il.com
Cc: amirv@...lanox.com, netdev@...r.kernel.org, yevgenyp@...lanox.com,
john.r.fastabend@...el.com
Subject: Re: [PATCH net-next V6 7/8] net/dcb: Add an optional max rate
attribute
From: Or Gerlitz <or.gerlitz@...il.com>
Date: Thu, 5 Apr 2012 01:27:29 +0300
> Or Gerlitz <or.gerlitz@...il.com> wrote:
>> John Fastabend <john.r.fastabend@...el.com> wrote:
>>> And I think the last comment. We really should have a comment here describing
>>> what the tc_maxrate field is. Its described in the commit log but its much
>>> harder for implementers to get it wrong when the struct is annotated.
>
>> Okay, John, sure, we can add that, so just to make sure, from your
>> side the series is okay once this comment is added, correct?
>
> Also, Dave, any further comments from you on this series, or with
> adding that comment John was asking for - the patches are all fine?
Yep, they seem mostly fine to me. So please resubmit with the comment
fix.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists