[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20120404.203448.1118889674233934663.davem@davemloft.net>
Date: Wed, 04 Apr 2012 20:34:48 -0400 (EDT)
From: David Miller <davem@...emloft.net>
To: cascardo@...ux.vnet.ibm.com
Cc: netdev@...r.kernel.org, roland@...nel.org, ogerlitz@...lanox.com,
yevgenyp@...lanox.co.il, alexg@...lanox.co.il,
klebers@...ux.vnet.ibm.com
Subject: Re: [PATCH] mlx4: allocate just enough pages instead of always 4
pages
From: Thadeu Lima de Souza Cascardo <cascardo@...ux.vnet.ibm.com>
Date: Wed, 4 Apr 2012 16:40:40 -0300
> The driver uses a 2-order allocation, which is too much on architectures
> like ppc64, which has a 64KiB page. This particular allocation is used
> for large packet fragments that may have a size of 512, 1024, 4096 or
> fill the whole allocation. So, a minimum size of 16384 is good enough
> and will be the same size that is used in architectures of 4KiB sized
> pages.
>
> This will avoid allocation failures that we see when the system is under
> stress, but still has plenty of memory, like the one below.
>
> This will also allow us to set the interface MTU to higher values like
> 9000, which was not possible on ppc64 without this patch.
...
> Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@...ux.vnet.ibm.com>
> Signed-off-by: Kleber Sacilotto de Souza <klebers@...ux.vnet.ibm.com>
> Tested-by: Kleber Sacilotto de Souza <klebers@...ux.vnet.ibm.com>
Applied, thanks a lot.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists