netdev - Re: [PATCH net-next] tcp: Fix bug when gap in rcv sequence is filled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 5 Apr 2012 15:21:50 -0400
From:	chetan loke <loke.chetan@...il.com>
To:	Vijay Subramanian <subramanian.vijay@...il.com>
Cc:	netdev@...r.kernel.org, davem@...emloft.net, ncardwell@...gle.com,
	ilpo.jarvinen@...sink.fi
Subject: Re: [PATCH net-next] tcp: Fix bug when gap in rcv sequence is filled

On Thu, Apr 5, 2012 at 2:46 PM, Vijay Subramanian
<subramanian.vijay@...il.com> wrote:
> +static int tcp_ofo_queue(struct sock *sk)
>  {
>        struct tcp_sock *tp = tcp_sk(sk);
>        __u32 dsack_high = tp->rcv_nxt;
>        struct sk_buff *skb;
> +       bool requeued = false; /*true if an skb is requeued to receive_queue*/

why introduce a bool then ? Change it to int(init to 0) and then
'return requeued' ?

Chetan
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html