netdev - Re: [RFC] net/hsr: Add support for IEC 62439-3 High-availability Seamless Redundancy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120405.183143.727226239038853914.davem@davemloft.net>
Date:	Thu, 05 Apr 2012 18:31:43 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	bhutchings@...arflare.com
Cc:	arvid.brodin@...a.com, shemminger@...tta.com,
	netdev@...r.kernel.org, balferreira@...glemail.com,
	arvid.brodin@...n.com
Subject: Re: [RFC] net/hsr: Add support for IEC 62439-3 High-availability
 Seamless Redundancy

From: Ben Hutchings <bhutchings@...arflare.com>
Date: Thu, 5 Apr 2012 20:21:08 +0100

> On Wed, 2012-04-04 at 20:17 -0400, David Miller wrote:
>> From: Arvid Brodin <arvid.brodin@...a.com>
>> Date: Thu, 5 Apr 2012 01:09:48 +0200
>> 
>> > -		icmp_param.data.icmph	   = *icmp_hdr(skb);
>> > +		memcpy(&icmp_param.data.icmph, icmp_hdr(skb),
>> > +						sizeof(icmp_param.data.icmph));
>> 
>> GCC can and will optimize this into an inline assignment, and thus
>> have the same unaligned access problems, because it determines
>> alignment based upon the types involved.
> 
> So presumably icmp_hdr() should be changed to skb_transport_header().

I would not say so.  Otherwise we introduce ugly casts everywhere.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html