netdev - Re: pull request: batman-adv 2012-04-05

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120405.191502.146577400943539254.davem@davemloft.net>
Date:	Thu, 05 Apr 2012 19:15:02 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	ordex@...istici.org
Cc:	netdev@...r.kernel.org, b.a.t.m.a.n@...ts.open-mesh.org
Subject: Re: pull request: batman-adv 2012-04-05

From: Antonio Quartulli <ordex@...istici.org>
Date: Thu,  5 Apr 2012 12:38:46 +0200

> This is my first pull-request, so I hope I've done everything in the right way,
> but please, fell free to blame me so that I can learn more :-)
> 
> I would like to propose the following changes for net-next/3.5. The first patch
> just adds a new maintainer for batman-adv; patches from 2 to 5 are cleanups
> and little fixes to make batman-adv re-use kernel defines/structures (ETH_ALEN
> and bitmap); patch 6 increases the default value of the "hop_penalty" parameter
> in order to encourage batman-adv to choose shorter routes; patches from 7 to 16
> consist in the renewal of the bridge loop avoidance mechanism (aka BLA2).
> BLA2 faces the same problem that STP tries to solve in classical switched
> networks, but in a layer 2 mesh. In this case the problem shows up when the user
> connects two nodes belonging to the same mesh by means of an ethernet bridge.
> It is possible to find much more details about BLA2 in our wiki [1,2,3].
> 
> As you can see its compile option is set to 'y' by default, but simply because
> this mechanism (actually its old version) was already part of the batman-adv
> core, but we decided to possibly let the users choose to remove it whether the
> network permits it and so reduce the binary size.

This series needs work.

1) Comments were added which were formatted like this:

	/* ...
	 * ... */

   Please fix all of these cases up to be:

	/* ...
	 * ...
	 */

2) Whan the bridge loop avoiding code is compiled out, you
   replace them with macros that of all things use varargs
   "..." instead of specifying correctly the arguments.

   In any event these should not be macros, but rather
   inline functions that do nothing, in order to get correct
   type checking.

   
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html