netdev - Re: [PATCH 0/7] bna: Update driver version to 3.0.23.0 (resubmit)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120404.201545.244323096520849467.davem@davemloft.net>
Date:	Wed, 04 Apr 2012 20:15:45 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	huangj@...cade.COM
Cc:	netdev@...r.kernel.org, AdapterLinuxOpenSrcExtTeam@...cade.COM
Subject: Re: [PATCH 0/7] bna: Update driver version to 3.0.23.0 (resubmit)

From: Jing Huang <huangj@...cade.COM>
Date: Wed, 4 Apr 2012 16:07:22 -0700

> The ioc init semaphore register is only used by driver. Firmware
> will never touch this register.  It will only be set to 1 when there
> is a driver instance holding it. So in practice, the infinite look
> will happen only if a driver instance grab the semaphore but forgot
> to release it. We add this logic to serialize register access for
> potential case of concurrent PCI function probe, which seems pretty
> rare in Linux.

Thanks for the clarification.

> I agree that this code looks ugly and wrong in theory. We will consider remove it or
> implement some timeout logic for it.

Ok, great.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html