netdev - Re: [PATCH net-next] rps: introduce a new sysctl switch rps_workaround_buggy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120405.064412.2145338934095035978.davem@davemloft.net>
Date:	Thu, 05 Apr 2012 06:44:12 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	raise.sail@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] rps: introduce a new sysctl switch
 rps_workaround_buggy_driver

From: Li Yu <raise.sail@...il.com>
Date: Thu, 05 Apr 2012 18:31:00 +0800

> 
> We encountered a buggy NIC driver or hardware/firmware, it keeps
> non-zero constant skb->rxhash for long time, so if we enabled RPS,
> the targeted CPU keeps same for long time too.
> 
> This patch introduces a sysctl switch to workaround for such problem,
> if the switch was on, RPS core discards the skb->rxhash that is
> computed by NIC hardware.
> 
> Hope this patch also can help others, thanks.
> 
> Signed-off-by Li Yu <bingtian.ly@...bao.com>

No way, we fix the drivers not add workarounds like this.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html