netdev - Re: Please revert removal of /sys/class/net/*/features

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1334089547.2624.4.camel@bwh-desktop.uk.solarflarecom.com>
Date:	Tue, 10 Apr 2012 21:25:47 +0100
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Michał Mirosław <mirq-linux@...e.qmqm.pl>
CC:	Stephen Hemminger <shemminger@...tta.com>,
	David Miller <davem@...emloft.net>, <netdev@...r.kernel.org>
Subject: Re: Please revert removal of /sys/class/net/*/features

On Tue, 2012-04-10 at 21:59 +0200, Michał Mirosław wrote:
> On Tue, Apr 10, 2012 at 11:08:51AM -0700, Stephen Hemminger wrote:
> > This commit needs to be reverted. It removed an available sysfs file, and sysfs
> > files are part of the ABI. It caused a bug in our current release of Vyatta because
> > the shell script was using the sysfs file to see if VLAN was supported on a device.
> > 
> > An API maybe redundant, but you can't just remove it.
> 
> There was a discussion about it before the patch was accepted. It was
> concluded that due to features flags changes, the /sys/class/net/*/features
> was never a stable API.

For reference:
http://thread.gmane.org/gmane.linux.network/199115/focus=199136

But note that the VLAN-related feature flags never actually changed
value.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html