| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAA93jw5opbBobzkgJ2diRPu2X0aKOsnF9hmcm_LfsLPipeAK7g@mail.gmail.com> Date: Tue, 10 Apr 2012 13:46:38 -0700 From: Dave Taht <dave.taht@...il.com> To: David Miller <davem@...emloft.net> Cc: ncardwell@...gle.com, netdev@...r.kernel.org, nanditad@...gle.com, ycheng@...gle.com, edumazet@...gle.com, therbert@...gle.com Subject: Re: [PATCH] tcp: fix tcp_rcv_rtt_update() use of an unscaled RTT sample On Tue, Apr 10, 2012 at 11:47 AM, David Miller <davem@...emloft.net> wrote: > From: Neal Cardwell <ncardwell@...gle.com> > Date: Tue, 10 Apr 2012 13:59:20 -0400 > >> Fix a code path in tcp_rcv_rtt_update() that was comparing scaled and >> unscaled RTT samples. >> >> The intent in the code was to only use the 'm' measurement if it was a >> new minimum. However, since 'm' had not yet been shifted left 3 bits >> but 'new_sample' had, this comparison would nearly always succeed, >> leading us to erroneously set our receive-side RTT estimate to the 'm' >> sample when that sample could be nearly 8x too high to use. >> >> The overall effect is to often cause the receive-side RTT estimate to >> be significantly too large (up to 40% too large for brief periods in >> my tests). >> >> Signed-off-by: Neal Cardwell <ncardwell@...gle.com> > > Applied, thanks. > -- awesome, is this needed in stable? -- Dave Täht SKYPE: davetaht US Tel: 1-239-829-5608 http://www.bufferbloat.net -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists