netdev - Re: [patch net-next 1/5] team: add support for per-port options

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120411.095846.959856257051027757.davem@davemloft.net>
Date:	Wed, 11 Apr 2012 09:58:46 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	jpirko@...hat.com
Cc:	netdev@...r.kernel.org, eric.dumazet@...il.com
Subject: Re: [patch net-next 1/5] team: add support for per-port options

From: Jiri Pirko <jpirko@...hat.com>
Date: Wed, 11 Apr 2012 07:43:51 +0200

> Tue, Apr 10, 2012 at 08:33:56PM CEST, davem@...emloft.net wrote:
>>From: Jiri Pirko <jpirko@...hat.com>
>>Date: Tue, 10 Apr 2012 17:15:42 +0200
>>
>>> @@ -81,7 +81,16 @@ EXPORT_SYMBOL(team_port_set_team_mac);
>>>   * Options handling
>>>   *******************/
>>>  
>>> -struct team_option *__team_find_option(struct team *team, const char *opt_name)
>>> +struct team_option_inst { /* One for each option instance */
>>> +	struct list_head list;
>>> +	struct team_option *option;
>>> +	struct team_port *port; /* != NULL if per-port */
>>> +	bool changed;
>>> +	bool removed;
>>> +};
>>> +
>>
>>All this indirection... just simply embed struct team_option into
>>struct team_option_inst instead of using a pointer, and allocate a
>>full team_option_inst where you currently memdup in the options.
> 
> Well the list of options is needed alone. When port is added/removed, this list
> gets iterated over and instances are created/deleted. Therefore I put
> pointer to option to option instance struct to save memory (and also to
> be nicer)

Fair enough, I'll apply this series, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html