netdev - Re: [PATCH] net: allow pskb_expand_head() to get maximum tailroom

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120411.101134.410148429938272473.davem@davemloft.net>
Date:	Wed, 11 Apr 2012 10:11:34 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	marc@...lins.org, Larry.Finger@...inger.net,
	bhutchings@...arflare.com, linux-wireless@...r.kernel.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH] net: allow pskb_expand_head() to get maximum tailroom

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Wed, 11 Apr 2012 08:08:39 +0200

> Marc Merlin reported many order-1 allocations failures in TX path on its
> wireless setup, that dont make any sense with MTU=1500 network, and non
> SG capable hardware.
> 
> Turns out part of the problem comes from pskb_expand_head() not using
> ksize() to get exact head size given by kmalloc(). Doing the same thing
> than __alloc_skb() allows more tailroom in skb and can prevent future
> reallocations.
> 
> As a bonus, struct skb_shared_info becomes cache line aligned.
> 
> Reported-by: Marc MERLIN <marc@...lins.org>
> Tested-by: Marc MERLIN <marc@...lins.org>
> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>

Applied and queued up for -stable.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html