netdev - Re: [B.A.T.M.A.N.] pull request: batman-adv 2012-04-11

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120411143102.GE19365@ritirata.org>
Date:	Wed, 11 Apr 2012 16:31:03 +0200
From:	Antonio Quartulli <ordex@...istici.org>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org, b.a.t.m.a.n@...ts.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] pull request: batman-adv 2012-04-11

On Wed, Apr 11, 2012 at 09:58:09 -0400, David Miller wrote:
> From: Antonio Quartulli <ordex@...istici.org>
> Date: Wed, 11 Apr 2012 15:03:03 +0200
> 
> >   git://git.open-mesh.org/linux-merge.git tags/batman-adv-for-davem
> > 
> > for you to fetch changes up to 7a5cc24277b57ce38eb0afa6634b71d4d5cc671e:
> > 
> >   batman-adv: add bridge loop avoidance compile option (2012-04-11 14:29:00 +0200)
> 
> Pulled, but I think the way you're doing the bridge loop avoidance stuff
> is wrong.
> 
> Don't use a Kconfig option, use a sysctl to turn the behavior off or on
> at runtime instead.

Hello David and thank you for your feedback.

Actually we have either the Kconfig option (for binary size purposes) AND a
boolean attribute in our soft_interface sysfs path (to dynamically turn the
bridge loop avoidance ON and OFF as you were suggesting).

Regards,

-- 
Antonio Quartulli

..each of us alone is worth nothing..
Ernesto "Che" Guevara

Content of type "application/pgp-signature" skipped