| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <4F870828.4020708@candelatech.com> Date: Thu, 12 Apr 2012 09:51:52 -0700 From: Ben Greear <greearb@...delatech.com> To: Florian Fainelli <florian@...nwrt.org> CC: linux-wireless@...r.kernel.org, netdev@...r.kernel.org Subject: Re: [PATCH 4/5] mac80211: Add more ethtools stats: survey, rates, etc On 04/12/2012 09:42 AM, Florian Fainelli wrote: > Hi, > > Le 04/12/12 18:32, greearb@...delatech.com a écrit : >> From: Ben Greear<greearb@...delatech.com> >> >> The signal and noise are forced to be positive since ethtool >> deals in unsigned 64-bit values and this number should be human >> readable. This gives easy access to some of the data formerly >> exposed in the deprecated /proc/net/wireless file. > > Uh, that's misleading, the signal and noise values are typically negative, so one needs to think about mentally adding a minus sign if he/she wants to > understand it. Does not ethtool know about 32-bits signed integers? Ethtool stats only supports u64. I think it's easy enough for humans or programs to add the negative sign. Can signal or noise ever be > 0? If so, that could actually break something that depends on flipping the value to negative.... Thanks, Ben -- Ben Greear <greearb@...delatech.com> Candela Technologies Inc http://www.candelatech.com -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists