netdev - Re: [PATCH] skbuff: struct ubuf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120413.130940.132638261191849442.davem@davemloft.net>
Date:	Fri, 13 Apr 2012 13:09:40 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	mst@...hat.com
Cc:	linux-kernel@...r.kernel.org, kvm@...r.kernel.org,
	virtualization@...ts.linux-foundation.org, netdev@...r.kernel.org,
	eric.dumazet@...il.com, ian.campbell@...rix.com, xma@...ibm.com,
	shemminger@...tta.com
Subject: Re: [PATCH] skbuff: struct ubuf_info callback type safety

From: "Michael S. Tsirkin" <mst@...hat.com>
Date: Mon, 9 Apr 2012 13:24:02 +0300

> The skb struct ubuf_info callback gets passed struct ubuf_info
> itself, not the arg value as the field name and the function signature
> seem to imply. Rename the arg field to ctx to match usage,
> add documentation and change the callback argument type
> to make usage clear and to have compiler check correctness.
> 
> Signed-off-by: Michael S. Tsirkin <mst@...hat.com>

Applied, thanks for fixing this Michael.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html