netdev - Re: [PATCH] bonding: start slaves with link down for ARP monitor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120414192554.GB8424@lion.mk-sys.cz>
Date:	Sat, 14 Apr 2012 21:25:54 +0200
From:	Michal Kubecek <mkubecek@...e.cz>
To:	Jay Vosburgh <fubar@...ibm.com>
Cc:	Flavio Leitner <fbl@...hat.com>, netdev@...r.kernel.org,
	Andy Gospodarek <andy@...yhouse.net>
Subject: Re: [PATCH] bonding: start slaves with link down for ARP monitor

On Fri, Apr 13, 2012 at 10:21:17PM -0700, Jay Vosburgh wrote:
>
>       The functional part I'm not sure about yet is if the this will
> cause slave devices with fast autoneg to wait for an ARP monitor cycle
> before going link up according to ARP monitor.
>
>       I think this may work better if the initial slave state is set
> to whatever netif_carrier_ok() says, instead of unconditionally up or
> down.

This would mean the initial state would be always up for drivers not
supporting netif_carrier_ok(). But as far as I can see, only a few such
drivers are left and they are not very frequent ones. So I agree it will
be less harm to keep starting with up link state for these drivers than
to introduce an unnecessary delay for cards/driver which are fast enough.

I'll send updated version of the patch after I test it.

                                                          Michal Kubecek

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html