netdev - Re: [PATCH net-next v3] tcp: bind() use stronger condition for bind

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120414.152914.905196046418805495.davem@davemloft.net>
Date:	Sat, 14 Apr 2012 15:29:14 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	alex.mihai.c@...il.com, fbl@...hat.com, kuznet@....inr.ac.ru,
	jmorris@...ei.org, yoshfuji@...ux-ipv6.org, kaber@...sh.net,
	netdev@...r.kernel.org, dbaluta@...acom.com
Subject: Re: [PATCH net-next v3] tcp: bind() use stronger condition for
 bind_conflict

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Fri, 13 Apr 2012 10:53:11 +0200

> On Fri, 2012-04-13 at 11:21 +0300, Alexandru Copot wrote:
>> From: Alex Copot <alex.mihai.c@...il.com>
>> 
>> We must try harder to get unique (addr, port) pairs when
>> doing port autoselection for sockets with SO_REUSEADDR
>> option set.
> 
> ...
> 
>>  			}
>> +			if (!relax && reuse && sk2->sk_reuse &&
>> +			   sk2->sk_state != TCP_LISTEN) {
>> +				const __be32 sk2_rcv_saddr = sk_rcv_saddr(sk2);
>> +
> 
> 
> Oh well, missing space here :(
> 
> I said :
> 
> if (condition_one ||
>     condition_two) {
> 
> not
> 
> if (condition_one ||
>    condition_two) {

I'll fix this up.

> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html