netdev - Re: [PATCH][trivial] ipv4: fix checkpatch errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120415.123851.786816332832233291.davem@davemloft.net>
Date:	Sun, 15 Apr 2012 12:38:51 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	dbaluta@...acom.com
Cc:	netdev@...r.kernel.org, trivial@...nel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH][trivial] ipv4: fix checkpatch errors

From: dbaluta@...acom.com
Date: Sun, 15 Apr 2012 14:34:41 +0300

> From: Daniel Baluta <dbaluta@...acom.com>
> 
> Fix checkpatch errors of the following type:
> 	* ERROR: "foo * bar" should be "foo *bar"
> 	* ERROR: "(foo*)" should be "(foo *)"
> 
> Signed-off-by: Daniel Baluta <dbaluta@...acom.com>

Applied, but:

> @@ -216,7 +216,7 @@ static struct rtnl_link_stats64 *ipgre_get_stats64(struct net_device *dev,
>  
>  /* Given src, dst and key, find appropriate for input tunnel. */
>  
> -static struct ip_tunnel * ipgre_tunnel_lookup(struct net_device *dev,
> +static struct ip_tunnel *ipgre_tunnel_lookup(struct net_device *dev,
>  					      __be32 remote, __be32 local,
>  					      __be32 key, __be16 gre_proto)
>  {

I had to reindent these function arguments on the lines after the one
you modified so that they continue to line up properly with the column
of the openning parenthesis on the previous line.

Do not blindly make checkpatch fixes without taking into consideration
the indentation modifications necessary in the context around your
change.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html