netdev - Re: [PATCH 0/9] atl1: add napi to Atheros L1 NIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120415.130346.1822341707659142562.davem@davemloft.net>
Date:	Sun, 15 Apr 2012 13:03:46 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	antonz@...allels.com
Cc:	netdev@...r.kernel.org, jcliburn@...il.com, csnook@...hat.com,
	khorenko@...allels.com
Subject: Re: [PATCH 0/9] atl1: add napi to Atheros L1 NIC

From: Tony Zelenoff <antonz@...allels.com>
Date: Fri, 13 Apr 2012 20:09:45 +0400

> Added NAPI interface to the driver of Atheros L1 NIC.
> RX speed reported by iperf in TCP mode (with and without -N
> switch) improved by ~7 Mbps. In UDP mode the speed up is
> improved by ~4 Mbps.
> Also hard RX/TX rings processing with memory allocation in
> interrupt handlers is not very good idea. So, fixed this.
> 
> Note: thouse patches must be applied after patch, that fix
> kernel panic in this driver.
> Its subject is: "atl1: fix kernel panic in case of DMA errors"

Unfortunately this is bullshit.  These patches actually depend upon
that bug fix not being applied.  Look at the patches, they reference
and use the reset workqueue the bug fix removed.

Anyways, I sorted through all of these merge hassles, and fixed up the
off-by-one bug Ben spotted in patch #2 because I was tired of waiting
and didn't want these patches to just keep rotting in patchwork.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html