netdev - Re: [PATCH v3] mac80211: Support on-channel scan option.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F8C57CC.4090505@sipsolutions.net>
Date:	Mon, 16 Apr 2012 10:33:00 -0700
From:	Johannes Berg <johannes@...solutions.net>
To:	greearb@...delatech.com
CC:	linux-wireless@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH v3] mac80211: Support on-channel scan option.

Did you test it?

> +		/* If we are scanning only on the current channel, then
> +		 * we do not need to stop normal activities
> +		 */
> +		unsigned long next_delay;
> +
> +		__set_bit(SCAN_ONCHANNEL_SCANNING,&local->scanning);
> +		ieee80211_recalc_idle(local);
> +		/* Notify driver scan is starting, keep order of operations
> +		 * same as normal software scan, in case that matters. */
> +		drv_sw_scan_start(local);
> +		ieee80211_configure_filter(local); /* accept probe-responses */
> +		/* We need to ensure power level is at max for scanning. */
> +		ieee80211_hw_config(local, 0);

a few blank lines would be nice :)

> +		if ((req->channels[0]->flags&
> +		     IEEE80211_CHAN_PASSIVE_SCAN) ||
> +		    !local->scan_req->n_ssids) {

That formatting is a bit off it seems. Or is that just my mailer?

johannes
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html