netdev - Re: tg3 'No PHY devices' loading issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120417205955.GC3932@decadent.org.uk>
Date:	Tue, 17 Apr 2012 21:59:55 +0100
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Josh Boyer <jwboyer@...hat.com>
Cc:	Matt Carlson <mcarlson@...adcom.com>,
	Michael Chan <mchan@...adcom.com>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: tg3 'No PHY devices' loading issue

On Tue, Apr 17, 2012 at 03:40:30PM -0400, Josh Boyer wrote:
> On Tue, Apr 17, 2012 at 08:10:42PM +0100, Ben Hutchings wrote:
> > On Tue, Apr 17, 2012 at 11:50:07AM -0700, Matt Carlson wrote:
> > > On Tue, Apr 17, 2012 at 10:18:57AM -0400, Josh Boyer wrote:
> > > > Hi Matt and Michael,
> > > > 
> > > > I'm seeing an odd issue with the tg3 driver on one of my development
> > > > machines.  I've tried kernels 3.2.10, 3.3.0, 3.3.1, 3.3.2 and 3.4-rc3
> > > > and they all seem to exhibit this issue now.  When the machine boots
> > > > and the tg3 driver is loaded, it fails to find a PHY and then reports
> > > > 'Problem fetching invariants of chip'.  If I do a rmmod/modprobe of
> > > > tg3 after login, the probe seems to work fine and ethernet works as
> > > > expected.  You can see this in the dmesg below:
> > [...]
> > > The 57788 uses the broadcom phylib module.  For some reason, it isn't
> > > available the first module load attempt.  A while ago, code was added to
> > > phylib to request modules from userspace if the particular phy support
> > > code wasn't already loaded.  It looks like this mechanism isn't working
> > > too well the first time through.
> > [...]
> > 
> > At a guess, tg3 is in the initramfs but broadcom isn't.
> 
> Good guess.  At least on one of the initramfs' I checked.  I'll verify
> the others, but it seems likely they match.  As I just said in my other
> reply, I would have expected tg3 to have a module dep on it to get it
> included in the initramfs built, but it seems that isn't the case.
 
tg3 doesn't use any symbols from broadcom, which is the only way
depmod can find dependencies.

In initramfs-tools (used in Debian and its derivatives) we just copy
all PHY drivers into the initramfs by default.  dracut should probably
do the same, at least when phylib is in the initramfs (or built into
the kernel).  (tg3 does use symbols from phylib.)

Ben.

-- 
Ben Hutchings
We get into the habit of living before acquiring the habit of thinking.
                                                              - Albert Camus
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html