lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20120417090110.GE2100@1984>
Date:	Tue, 17 Apr 2012 11:01:10 +0200
From:	Pablo Neira Ayuso <pablo@...filter.org>
To:	Gao feng <gaofeng@...fujitsu.com>
Cc:	netfilter-devel@...r.kernel.org, netdev@...r.kernel.org,
	ebiederm@...ssion.com, serge.hallyn@...onical.com,
	dlezcano@...ibm.com
Subject: Re: [PATCH 12/12] netfilter: export necessary function for generic
 proto

On Tue, Apr 17, 2012 at 10:56:23AM +0800, Gao feng wrote:
> export two functions nf_conntrack_proto_generic_net_init and
> nf_conntrack_proto_generic_net_fini.
> 
> Signed-off-by: Gao feng <gaofeng@...fujitsu.com>
> ---
>  include/net/netfilter/nf_conntrack_core.h |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/include/net/netfilter/nf_conntrack_core.h b/include/net/netfilter/nf_conntrack_core.h
> index aced085..3c3fabe 100644
> --- a/include/net/netfilter/nf_conntrack_core.h
> +++ b/include/net/netfilter/nf_conntrack_core.h
> @@ -31,6 +31,9 @@ extern void nf_conntrack_cleanup(struct net *net);
>  extern int nf_conntrack_proto_init(void);
>  extern void nf_conntrack_proto_fini(void);
>  
> +extern int nf_conntrack_proto_generic_net_init(struct net *net);
> +extern void nf_conntrack_proto_generic_net_fini(struct net *net);

This does not require a separated patch only for this.

Please, review the logic that you've follow to split changes.

Thank you.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ