netdev - Re: [PATCH 3/3] ehea: do not dereference possible NULL port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120417.222912.1038252957653077871.davem@davemloft.net>
Date:	Tue, 17 Apr 2012 22:29:12 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	cascardo@...ux.vnet.ibm.com
Cc:	netdev@...r.kernel.org, joe@...ches.com
Subject: Re: [PATCH 3/3] ehea: do not dereference possible NULL port

From: Thadeu Lima de Souza Cascardo <cascardo@...ux.vnet.ibm.com>
Date: Tue, 17 Apr 2012 11:41:55 -0300

> port may be NULL when we receive an interrupt too early in the probe.
> 
> commit 8c4877a4128e7931077b024a891a4b284d8756a3, in particular, has
> introduced this problem in the case of port state change interrupt.
> 
> This causes crashes in some situations:

Never fix this kind of bug like this.  Do not make a tasklet or
an irq handler pay the price of the probe not doing things in the
right order.

Do not register asynchronous threads of control until all the
state is setup properly.

That's the right way to fix this problem.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html