netdev - Re: [patch] bnx2x: off by one in bnx2x_ets_e3b0_sp_pri_to_cos

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1334741227.12363.5.camel@lb-tlvb-eilong.il.broadcom.com>
Date:	Wed, 18 Apr 2012 12:27:07 +0300
From:	"Eilon Greenstein" <eilong@...adcom.com>
To:	"Dan Carpenter" <dan.carpenter@...cle.com>
cc:	netdev@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [patch] bnx2x: off by one in
 bnx2x_ets_e3b0_sp_pri_to_cos_set()

On Wed, 2012-04-18 at 09:53 +0300, Dan Carpenter wrote:
> The sp_pri_to_cos[] array size depends on the config but lets say it is
> BX_E3B0_MAX_NUM_COS_PORT0 and max_num_of_cos is also
> DCBX_E3B0_MAX_NUM_COS_PORT0.  In the original code
> "pri == max_num_of_cos" was accepted but it is one past the end of the
> array.
> 
> Also we used "pri" before capping it.  It's a harmless read past the end
> of the array, but it would affect which error message gets printed.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
> 

Acked-by: Eilon Greenstein <eilong@...adcom.com>

Thanks Dan - this is obviously better.



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html